A study of the quality-impacting practices of modern code review at Sony mobile

Junji Shimagaki, Yasutaka Kamei, Shane McIntosh, Ahmed E. Hassan, Naoyasu Ubayashi

Research output: Chapter in Book/Report/Conference proceedingConference contribution

13 Citations (Scopus)

Abstract

Nowadays, a flexible, lightweight variant of the code review process (i.e., the practice of having other team members critique software changes) is adopted by open source and proprietary software projects. While this flexibility is a blessing (e.g., enabling code reviews to span the globe), it does not mandate minimum review quality criteria like the formal code inspections of the past. Recent work shows that lax reviewing can impact the quality of open source systems. In this paper, we investigate the impact that code reviewing practices have on the quality of a proprietary system that is developed by Sony Mobile. We begin by replicating open source analyses of the relationship between software quality (as approximated by post-release defect-proneness) and: (1) code review coverage, i.e., the proportion of code changes that have been reviewed and (2) code review participation, i.e., the degree of reviewer involvement in the code review process. We also perform a qualitative analysis, with a survey of 93 stakeholders, semi-structured interviews with 15 stakeholders, and a follow-up survey of 25 senior engineers. Our results indicate that while past measures of review coverage and participation do not share a relationship with defect-proneness at Sony Mobile, reviewing measures that are aware of the Sony Mobile development context are associated with defect-proneness. Our results have lead to improvements of the Sony Mobile code review process.

Original languageEnglish
Title of host publicationProceedings - 5th International Workshop on Green and Sustainable Software, GREENS 2016
PublisherIEEE Computer Society
Pages212-221
Number of pages10
ISBN (Electronic)9781450341615, 9781450342056
DOIs
Publication statusPublished - May 14 2016
Event2016 IEEE/ACM 38th IEEE International Conference on Software Engineering, ICSE 2016 - Austin, United States
Duration: May 14 2016May 22 2016

Other

Other2016 IEEE/ACM 38th IEEE International Conference on Software Engineering, ICSE 2016
CountryUnited States
CityAustin
Period5/14/165/22/16

Fingerprint

Defects
Inspection
Engineers

All Science Journal Classification (ASJC) codes

  • Software

Cite this

Shimagaki, J., Kamei, Y., McIntosh, S., Hassan, A. E., & Ubayashi, N. (2016). A study of the quality-impacting practices of modern code review at Sony mobile. In Proceedings - 5th International Workshop on Green and Sustainable Software, GREENS 2016 (pp. 212-221). IEEE Computer Society. https://doi.org/10.1145/2889160.2889243

A study of the quality-impacting practices of modern code review at Sony mobile. / Shimagaki, Junji; Kamei, Yasutaka; McIntosh, Shane; Hassan, Ahmed E.; Ubayashi, Naoyasu.

Proceedings - 5th International Workshop on Green and Sustainable Software, GREENS 2016. IEEE Computer Society, 2016. p. 212-221.

Research output: Chapter in Book/Report/Conference proceedingConference contribution

Shimagaki, J, Kamei, Y, McIntosh, S, Hassan, AE & Ubayashi, N 2016, A study of the quality-impacting practices of modern code review at Sony mobile. in Proceedings - 5th International Workshop on Green and Sustainable Software, GREENS 2016. IEEE Computer Society, pp. 212-221, 2016 IEEE/ACM 38th IEEE International Conference on Software Engineering, ICSE 2016, Austin, United States, 5/14/16. https://doi.org/10.1145/2889160.2889243
Shimagaki J, Kamei Y, McIntosh S, Hassan AE, Ubayashi N. A study of the quality-impacting practices of modern code review at Sony mobile. In Proceedings - 5th International Workshop on Green and Sustainable Software, GREENS 2016. IEEE Computer Society. 2016. p. 212-221 https://doi.org/10.1145/2889160.2889243
Shimagaki, Junji ; Kamei, Yasutaka ; McIntosh, Shane ; Hassan, Ahmed E. ; Ubayashi, Naoyasu. / A study of the quality-impacting practices of modern code review at Sony mobile. Proceedings - 5th International Workshop on Green and Sustainable Software, GREENS 2016. IEEE Computer Society, 2016. pp. 212-221
@inproceedings{e6df2719573748eebffd9b23c2c0ef29,
title = "A study of the quality-impacting practices of modern code review at Sony mobile",
abstract = "Nowadays, a flexible, lightweight variant of the code review process (i.e., the practice of having other team members critique software changes) is adopted by open source and proprietary software projects. While this flexibility is a blessing (e.g., enabling code reviews to span the globe), it does not mandate minimum review quality criteria like the formal code inspections of the past. Recent work shows that lax reviewing can impact the quality of open source systems. In this paper, we investigate the impact that code reviewing practices have on the quality of a proprietary system that is developed by Sony Mobile. We begin by replicating open source analyses of the relationship between software quality (as approximated by post-release defect-proneness) and: (1) code review coverage, i.e., the proportion of code changes that have been reviewed and (2) code review participation, i.e., the degree of reviewer involvement in the code review process. We also perform a qualitative analysis, with a survey of 93 stakeholders, semi-structured interviews with 15 stakeholders, and a follow-up survey of 25 senior engineers. Our results indicate that while past measures of review coverage and participation do not share a relationship with defect-proneness at Sony Mobile, reviewing measures that are aware of the Sony Mobile development context are associated with defect-proneness. Our results have lead to improvements of the Sony Mobile code review process.",
author = "Junji Shimagaki and Yasutaka Kamei and Shane McIntosh and Hassan, {Ahmed E.} and Naoyasu Ubayashi",
year = "2016",
month = "5",
day = "14",
doi = "10.1145/2889160.2889243",
language = "English",
pages = "212--221",
booktitle = "Proceedings - 5th International Workshop on Green and Sustainable Software, GREENS 2016",
publisher = "IEEE Computer Society",
address = "United States",

}

TY - GEN

T1 - A study of the quality-impacting practices of modern code review at Sony mobile

AU - Shimagaki, Junji

AU - Kamei, Yasutaka

AU - McIntosh, Shane

AU - Hassan, Ahmed E.

AU - Ubayashi, Naoyasu

PY - 2016/5/14

Y1 - 2016/5/14

N2 - Nowadays, a flexible, lightweight variant of the code review process (i.e., the practice of having other team members critique software changes) is adopted by open source and proprietary software projects. While this flexibility is a blessing (e.g., enabling code reviews to span the globe), it does not mandate minimum review quality criteria like the formal code inspections of the past. Recent work shows that lax reviewing can impact the quality of open source systems. In this paper, we investigate the impact that code reviewing practices have on the quality of a proprietary system that is developed by Sony Mobile. We begin by replicating open source analyses of the relationship between software quality (as approximated by post-release defect-proneness) and: (1) code review coverage, i.e., the proportion of code changes that have been reviewed and (2) code review participation, i.e., the degree of reviewer involvement in the code review process. We also perform a qualitative analysis, with a survey of 93 stakeholders, semi-structured interviews with 15 stakeholders, and a follow-up survey of 25 senior engineers. Our results indicate that while past measures of review coverage and participation do not share a relationship with defect-proneness at Sony Mobile, reviewing measures that are aware of the Sony Mobile development context are associated with defect-proneness. Our results have lead to improvements of the Sony Mobile code review process.

AB - Nowadays, a flexible, lightweight variant of the code review process (i.e., the practice of having other team members critique software changes) is adopted by open source and proprietary software projects. While this flexibility is a blessing (e.g., enabling code reviews to span the globe), it does not mandate minimum review quality criteria like the formal code inspections of the past. Recent work shows that lax reviewing can impact the quality of open source systems. In this paper, we investigate the impact that code reviewing practices have on the quality of a proprietary system that is developed by Sony Mobile. We begin by replicating open source analyses of the relationship between software quality (as approximated by post-release defect-proneness) and: (1) code review coverage, i.e., the proportion of code changes that have been reviewed and (2) code review participation, i.e., the degree of reviewer involvement in the code review process. We also perform a qualitative analysis, with a survey of 93 stakeholders, semi-structured interviews with 15 stakeholders, and a follow-up survey of 25 senior engineers. Our results indicate that while past measures of review coverage and participation do not share a relationship with defect-proneness at Sony Mobile, reviewing measures that are aware of the Sony Mobile development context are associated with defect-proneness. Our results have lead to improvements of the Sony Mobile code review process.

UR - http://www.scopus.com/inward/record.url?scp=85013069278&partnerID=8YFLogxK

UR - http://www.scopus.com/inward/citedby.url?scp=85013069278&partnerID=8YFLogxK

U2 - 10.1145/2889160.2889243

DO - 10.1145/2889160.2889243

M3 - Conference contribution

AN - SCOPUS:85013069278

SP - 212

EP - 221

BT - Proceedings - 5th International Workshop on Green and Sustainable Software, GREENS 2016

PB - IEEE Computer Society

ER -