Anti-patterns in Modern Code Review: Symptoms and Prevalence

Moataz Chouchen, Ali Ouni, Raula Gaikovina Kula, Dong Wang, Patanamon Thongtanunam, Mohamed Wiem Mkaouer, Kenichi Matsumoto

Research output: Chapter in Book/Report/Conference proceedingConference contribution

8 Citations (Scopus)

Abstract

Modern code review (MCR) is now broadly adopted as an established and effective software quality assurance practice, with an increasing number of open-source as well as commercial software projects identifying code review as a crucial practice. During the MCR process, developers review, provide constructive feedback, and/or critique each others' patches before a code change is merged into the codebase. Nevertheless, code review is basically a human task that involves technical, personal and social aspects. Existing literature hint the existence of poor reviewing practices i.e., anti-patterns, that may contribute to a tense reviewing culture, degradation of software quality, slow down integration, and may affect the overall sustainability of the project. To better understand these practices, we present in this paper the concept of Modern Code Review Anti-patterns (MCRA) and take a first step to define a catalog that enumerates common poor code review practices. In detail we explore and characterize MCRA symptoms, causes, and impacts. We also conduct a series of preliminary experiments to investigate the prevalence and co-occurrences of such anti-patterns on a random sample of 100 code reviews from various OpenStack projects.

Original languageEnglish
Title of host publicationProceedings - 2021 IEEE International Conference on Software Analysis, Evolution and Reengineering, SANER 2021
PublisherInstitute of Electrical and Electronics Engineers Inc.
Pages531-535
Number of pages5
ISBN (Electronic)9781728196305
DOIs
Publication statusPublished - Mar 2021
Externally publishedYes
Event28th IEEE International Conference on Software Analysis, Evolution and Reengineering, SANER 2021 - Virtual, Honolulu, United States
Duration: Mar 9 2021Mar 12 2021

Publication series

NameProceedings - 2021 IEEE International Conference on Software Analysis, Evolution and Reengineering, SANER 2021

Conference

Conference28th IEEE International Conference on Software Analysis, Evolution and Reengineering, SANER 2021
Country/TerritoryUnited States
CityVirtual, Honolulu
Period3/9/213/12/21

All Science Journal Classification (ASJC) codes

  • Artificial Intelligence
  • Software
  • Safety, Risk, Reliability and Quality

Fingerprint

Dive into the research topics of 'Anti-patterns in Modern Code Review: Symptoms and Prevalence'. Together they form a unique fingerprint.

Cite this